Skip to content

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Jun 2, 2025

Summary

This tests and ensures that defaulting works as expected inside Go templates.

Related Issue(s)

Fixes #25

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 2, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Jun 2, 2025

/kind cleanup

@kcp-ci-bot kcp-ci-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 2, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Jun 2, 2025

/retest

Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0b551519069d3f96a49b08e914bb0688d6ff36b3

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2025
@kcp-ci-bot kcp-ci-bot merged commit 1b5392e into main Jun 3, 2025
9 checks passed
@kcp-ci-bot kcp-ci-bot deleted the template-defaults branch June 3, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: support defaults for related resource references

4 participants